fix: Fix external links #5754
Merged
fix: Fix external links #5754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5754 +/- ##
==========================================
- Coverage 9.54% 7.01% -2.54%
==========================================
Files 325 407 +82
Lines 16411 21816 +5405
==========================================
- Hits 1567 1530 -37
- Misses 14844 20286 +5442 ☔ View full report in Codecov by Sentry. |
teolemon
approved these changes
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
We have several issues with external links:
First, from the tagline, instead of pushing a route with the
push()method, we usedgo(); thus clearing the history.Second, due to bugs, we now force the external browser on non-Android platforms, as it's broken otherwise.
Third, with external links, we may have no history (due to the
go()method) -> in that case, we go back to the homepage.Fourth, external links with multiple levels (eg:
cgi/reset_password.pl) were ignored by GoRouterIt will fix #5750 and #5753